-
Notifications
You must be signed in to change notification settings - Fork 312
Fix: dataclass InitVars shouldn't be required on serialization
#1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
022e730
fix dataclass initvars not required on serialization
sydney-runkle 2d0b850
Merge branch 'main' into fix-initvar-required
sydney-runkle 327c60a
ensuring warning free serialization
sydney-runkle 109749a
remove unhelpful test
sydney-runkle 2d73a66
alternative solution
sydney-runkle 3a027b5
skip init only fields
sydney-runkle 369bed3
first pass as repro test
sydney-runkle 42a98c1
simplify test
sydney-runkle e2f256f
only add to fields if not init only, fixing linting
sydney-runkle 9ab1140
minify diff + add new test
sydney-runkle 825fb9e
revert and use guard clause
sydney-runkle 5cc59c2
revert lock changes
sydney-runkle 14b6931
Merge branch 'main' into fix-initvar-required
sydney-runkle 3e82624
whitespace
sydney-runkle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.