feat: add uv facts and operations #1500
Conversation
maisim
left a comment
maisim
left a comment
There was a problem hiding this comment.
Code review + functionnal tests
src/pyinfra/operations/uv.py
Outdated
| extras = " ".join(extra_args or []) if not isinstance(extra_args, str) else extra_args | ||
| install_command = f"{UV_CMD} tool install --no-progress {extras}" | ||
| uninstall_command = f"{UV_CMD} tool uninstall --no-progress {extras}" | ||
| upgrade_command = f"{install_command} --upgrade --no-progress {extras}" |
There was a problem hiding this comment.
--> Starting operation: Ensure cowsay tool is installed
[@Local] error: the argument '--no-progress' cannot be used multiple times
| upgrade_command = f"{install_command} --upgrade --no-progress {extras}" | |
| upgrade_command = f"{install_command} --upgrade {extras}" |
There was a problem hiding this comment.
But I don't quite understand why the tests are still passing without needing an update, since the command syntax shouldn't be correct anymore, right? Perhaps it's an untested case? I don't have time to look into it further right now; I'll come back to it later.
There was a problem hiding this comment.
Ignore my previous (now deleted) reply as I'm also confused: below is the code I see in changed files (just made the screenshot now) which doesn't have the problem (and explains why the tests passed) but doesn't explain why @maisim sees different (broken) code.
There was a problem hiding this comment.
Hi @morrison12
You have to look at line 175
https://github.com/pyinfra-dev/pyinfra/pull/1500/files#r2695177204
I submitted a PR on your fork to fix this:
https://github.com/morrison12/pyinfra/pull/1/changes
There is no error because no test on this part ;)
There was a problem hiding this comment.
oops.. indeed wrong operation.. thanks.. merged
fix: fix upgrade command for uv tool installation and add a test
2 participants
Add initial set of facts and operations for
uv.Comments and Suggestions welcome.
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)