-
Notifications
You must be signed in to change notification settings - Fork 344
Migrate to prior module from pymc-extras #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
- Coverage 92.44% 92.17% -0.27%
==========================================
Files 63 63
Lines 7660 7287 -373
==========================================
- Hits 7081 6717 -364
+ Misses 579 570 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
How should we proceed? Is min python version change an issue? |
|
From https://pypistats.org/packages/pymc-marketing
Python 3.10 has around 12% share and it has been going down. So I think we can do it for 0.16.0 . That is, we can merge now once the merge conflicts are solved :) |
|
pre-commit.ci autofix |
|
@williambdean let's merge this one now :) as we now officially dropped support for python 3.10 |
|
Agh, errors will be fixed by #1852 |
Done! |
|
What do you think about fe6f2ee ? If you are happy we can merge :) |
|
Lets merge! |
|
Im merging this one so that we don't delay it any longer. A notebook is failing due to #1849 We will fix that in a following PR |


Description
Adding the dependency of pymc-extras to use the prior module from there
Related Issue
Checklist
pre-commit.ci autofixto auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1767.org.readthedocs.build/en/1767/