Skip to content

Conversation

@williambdean
Copy link
Contributor

@williambdean williambdean commented Jun 16, 2025

Description

Adding the dependency of pymc-extras to use the prior module from there

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1767.org.readthedocs.build/en/1767/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation CLV customer choice Related to customer choice module Bass model Dealing with the Bass Defusion model labels Jun 16, 2025
@williambdean williambdean added deprecation and removed docs Improvements or additions to documentation CLV customer choice Related to customer choice module Bass model Dealing with the Bass Defusion model labels Jun 16, 2025
@github-actions github-actions bot added docs Improvements or additions to documentation CLV customer choice Related to customer choice module Bass model Dealing with the Bass Defusion model labels Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

❌ Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.17%. Comparing base (84fc81a) to head (79b217d).
⚠️ Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/deserialize.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
- Coverage   92.44%   92.17%   -0.27%     
==========================================
  Files          63       63              
  Lines        7660     7287     -373     
==========================================
- Hits         7081     6717     -364     
+ Misses        579      570       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@williambdean williambdean requested review from cetagostini and juanitorduz and removed request for cetagostini June 16, 2025 22:54
@williambdean
Copy link
Contributor Author

How should we proceed? Is min python version change an issue?

@juanitorduz
Copy link
Collaborator

From

https://pypistats.org/packages/pymc-marketing

image

Python 3.10 has around 12% share and it has been going down. So I think we can do it for 0.16.0 . That is, we can merge now once the merge conflicts are solved :)

@williambdean
Copy link
Contributor Author

pre-commit.ci autofix

@juanitorduz
Copy link
Collaborator

@williambdean let's merge this one now :) as we now officially dropped support for python 3.10

@juanitorduz
Copy link
Collaborator

I do not understand the error on the CI

image

@juanitorduz juanitorduz added this to the 0.16.0 milestone Jul 25, 2025
@juanitorduz
Copy link
Collaborator

Agh, errors will be fixed by #1852

@juanitorduz
Copy link
Collaborator

Agh, errors will be fixed by #1852

Done!

@juanitorduz
Copy link
Collaborator

What do you think about fe6f2ee ? If you are happy we can merge :)

@williambdean
Copy link
Contributor Author

Lets merge!

@juanitorduz juanitorduz merged commit b446fb5 into main Jul 26, 2025
33 of 34 checks passed
@juanitorduz juanitorduz deleted the pymc-extras branch July 26, 2025 06:27
@juanitorduz
Copy link
Collaborator

Im merging this one so that we don't delay it any longer. A notebook is failing due to #1849

We will fix that in a following PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bass model Dealing with the Bass Defusion model CLV customer choice Related to customer choice module deprecation docs Improvements or additions to documentation maintenance major API breaking changes MMM Prior class tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Prior class from pymc-extras

4 participants