-
-
Notifications
You must be signed in to change notification settings - Fork 361
Pass repo URL to keyring instead of repo name
#2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keyring.get_password() (closes #1986)keyring.get_password()
|
This is code I am less familiar with, can you investigate why this change is causing failures on Linux? |
It is failing in general, the publishing tests are skipped for non-Linux platforms Lines 243 to 246 in c7575ad
I'll try to look into it |
|
Tests are passing now, PR may be merged |
keyring.get_password()keyring instead of repo name
|
@cjames23 this one is ready to be merged |
cjames23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Closes #1986