Skip to content

Conversation

@valentinoli
Copy link
Contributor

Closes #1986

@valentinoli valentinoli changed the title fix: pass repo URL to keyring.get_password() (closes #1986) Pass repo URL to keyring.get_password() Dec 12, 2025
@cjames23
Copy link
Member

This is code I am less familiar with, can you investigate why this change is causing failures on Linux?

@valentinoli
Copy link
Contributor Author

valentinoli commented Dec 29, 2025

This is code I am less familiar with, can you investigate why this change is causing failures on Linux?

It is failing in general, the publishing tests are skipped for non-Linux platforms

hatch/tests/conftest.py

Lines 243 to 246 in c7575ad

if not shutil.which("docker") or (
running_in_ci() and (not PLATFORM.linux or platform.python_implementation() == "PyPy")
):
pytest.skip("Not testing publishing")

I'll try to look into it

@valentinoli
Copy link
Contributor Author

@cjames23

Tests are passing now, PR may be merged

@valentinoli valentinoli changed the title Pass repo URL to keyring.get_password() Pass repo URL to keyring instead of repo name Dec 29, 2025
@valentinoli
Copy link
Contributor Author

@cjames23 this one is ready to be merged

Copy link
Member

@cjames23 cjames23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@cjames23 cjames23 merged commit 8783049 into pypa:master Jan 8, 2026
49 checks passed
github-actions bot pushed a commit to sysfce2/python-hatchling that referenced this pull request Jan 11, 2026
* fix: pass repo URL to `keyring.get_password()` (closes pypa#1986)

* fix: pass repo URL to `keyring.set_password()` when caching creds

---------

Co-authored-by: Cary Hawkins <hawkinscary23@gmail.com> 8783049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publish: fails to obtain credentials from keyring

2 participants