Merged
Conversation
maiksprenger
added a commit
to maiksprenger/django-mermaid
that referenced
this pull request
Mar 25, 2025
This is a follow-up to pysnippet#20 pysnippet#21 added a CDN feature, which means the added script tag will point to the CDN version of mermaid.js. But it still tries to download a copy to the package's static directory in AppConfig.ready. Because this isn't necessary in CDN mode and causes us a PermissionError during deployment, I'm proposing we only download in non-CDN mode.
maiksprenger
added a commit
to maiksprenger/django-mermaid
that referenced
this pull request
Mar 25, 2025
This is a follow-up to pysnippet#20 pysnippet#21 added a CDN feature, which means the added script tag will point to the CDN version of mermaid.js. But it still tries to download a copy to the package's static directory in AppConfig.ready. Because this isn't necessary in CDN mode and causes us a PermissionError during deployment, I'm proposing we only download in non-CDN mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In the scope of #20, this PR implements a feature suggested by @maiksprenger. The idea was to use the CDN URL directly without creating a local copy as a static file.
All Submissions:
Changes to Core Features: