-
Notifications
You must be signed in to change notification settings - Fork 652
fix: Fix Mac OS downloading #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71zenith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a different naming case would have been nice
|
Hi there, I created the issue related to this PR. I have tested it on: As far as testing my use case and some various of the above use cases worked as well. Thanks @Lockl00p |
@ryuuskylark |
|
Sorry that I was not clear...
Everything worked perfectly, besides a connection to vlc on mac failing, this is completely unrelated to ani-cli on my side.
Thank you
…---- On Sun, 11 May 2025 19:20:17 +0200 ***@***.*** wrote ----
Lockl00p left a comment #1517 (comment)
As far as testing my use case and some various of the above use cases worked as well. I seem to have had an issue with it connecting to vlc worked perfectly for my use cases.
https://github.com/ryuuskylark
Wait so does it not work with iina?
—
Reply to this email directly, #1517 (comment), or https://github.com/notifications/unsubscribe-auth/ANWQT76LM5VYNP3CPODXE3D256BFDAVCNFSM6AAAAAB4UZUMLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZQGAYTIMJRHE.
You are receiving this because you were mentioned.
|
|
Thanks for the clarification, mate! |
Adajone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to reproduce #1513 with this fix 👍
|
I left a comment in #1513 |
Pull Request Template
Type of change
Description
A simple fix to make asynch-dns = false only apply to iOS
The items not marked don’t work on iOS (likely due to how you can only launch VLC with the link and nothing more)
also, this wasn’t tested on Mac OS as I do not have a Mac. It should work tho
Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-e(select episode) aka-r(range selection) works-Sselect index works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--exit-after-playauto exit after playing works--nextep-countdowncountdown to next ep works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases