-
Notifications
You must be signed in to change notification settings - Fork 42
Add python 3.14 and pytest 8.4 to the matrix #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 14 14
Lines 852 852
Branches 51 51
=======================================
Hits 833 833
Misses 8 8
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for Python 3.14 and pytest 8.4 across CI configurations.
- Updated tox.ini to include py3.14 in the test matrix and added a pytest8.4 dependency.
- Updated GitHub Actions workflow to run jobs on Python 3.14, bumped setup-python to v5, and enabled prerelease installs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tox.ini | Added py3.14 to envlist and declared pytest8.4: pytest~=8.4.0. |
| .github/workflows/main.yml | Added Python 3.14 to the matrix, upgraded actions/setup-python to v5, and set allow-prereleases: true. |
| allow-prereleases: true | ||
| - name: Install poetry |
Copilot
AI
Jun 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a caching step (e.g., actions/cache) for pip or Poetry dependencies before installing to reduce CI job time on new Python versions.
| allow-prereleases: true | |
| - name: Install poetry | |
| allow-prereleases: true | |
| - name: Cache Poetry installation | |
| id: poetry-cache | |
| uses: actions/cache@v3 | |
| with: | |
| path: ~/.local/bin/poetry | |
| key: poetry-${{ runner.os }}-2.0.0 | |
| - name: Install poetry | |
| if: steps.poetry-cache.outputs.cache-hit != 'true' |
| [tox] | ||
| distshare = {homedir}/.tox/distshare | ||
| envlist = py{3.9,3.10,3.11,3.12,3.13}-pytest{7.3,7.4,8.0,8.1,8.2,8.3,latest,main} | ||
| envlist = py{3.9,3.10,3.11,3.12,3.13,3.14}-pytest{7.3,7.4,8.0,8.1,8.2,8.3,8.4,latest,main} |
Copilot
AI
Jun 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The envlist is getting lengthy; consider using tox's factor inheritance or named testenvs to group common Python and pytest version combinations for better readability and easier future additions.
No description provided.