Skip to content

Add python 3.14 and pytest 8.4 to the matrix #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

Add python 3.14 and pytest 8.4 to the matrix #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,18 @@ jobs:
toxfactor: py3.13
ignore-typecheck-outcome: true
ignore-test-outcome: false
- python-version: "3.14"
toxfactor: py3.14
ignore-typecheck-outcome: true
ignore-test-outcome: false
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install poetry
Comment on lines +68 to 69
Copy link

Copilot AI Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a caching step (e.g., actions/cache) for pip or Poetry dependencies before installing to reduce CI job time on new Python versions.

Suggested change
allow-prereleases: true
- name: Install poetry
allow-prereleases: true
- name: Cache Poetry installation
id: poetry-cache
uses: actions/cache@v3
with:
path: ~/.local/bin/poetry
key: poetry-${{ runner.os }}-2.0.0
- name: Install poetry
if: steps.poetry-cache.outputs.cache-hit != 'true'

Copilot uses AI. Check for mistakes.
run: |
python -m pip install poetry==2.0.0
Expand Down
3 changes: 2 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
distshare = {homedir}/.tox/distshare
envlist = py{3.9,3.10,3.11,3.12,3.13}-pytest{7.3,7.4,8.0,8.1,8.2,8.3,latest,main}
envlist = py{3.9,3.10,3.11,3.12,3.13,3.14}-pytest{7.3,7.4,8.0,8.1,8.2,8.3,8.4,latest,main}
Copy link

Copilot AI Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The envlist is getting lengthy; consider using tox's factor inheritance or named testenvs to group common Python and pytest version combinations for better readability and easier future additions.

Copilot uses AI. Check for mistakes.
py{3.9,3.10,3.11}-pytest{7.0,7.1,7.2}
mypy

Expand All @@ -12,6 +12,7 @@ ignore_outcome =
deps =
pytestlatest: pytest
pytestmain: git+https://github.com/pytest-dev/pytest.git@main
pytest8.4: pytest~=8.4.0
pytest8.3: pytest~=8.3.0
pytest8.2: pytest~=8.2.0
pytest8.1: pytest~=8.1.0
Expand Down
Loading