Skip to content

Add test coverage for OSError handling in get_user() for Python 3.13+ compatibility #13836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add test coverage for OSError handling in get_user() for Python 3.13+ compatibility #13836

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
669e259
Initial plan
Copilot Oct 21, 2025
9fae572
Add test for OSError handling in get_user()
Copilot Oct 21, 2025
a5c2118
Fix test to skip on non-Windows and use direct env var removal
Copilot Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions testing/test_tmpdir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,22 @@ def test_get_user(monkeypatch):
assert get_user() is None


def test_get_user_handles_oserror(monkeypatch):
"""Test that get_user() returns None when getpass.getuser() raises OSError.

This handles the Python 3.13+ behavior where getpass.getuser() raises
OSError when no username environment variables (LOGNAME, USER, LNAME,
USERNAME) are set on Windows (#11874).
"""
import getpass

def mock_getuser():
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot this tests the wrong thing

The test shoul skip on non affected platforms and use direct values

Copy link
Author

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit 9c8e8d8. The test now:

  • Skips on non-Windows platforms using @pytest.mark.skipif(not sys.platform.startswith("win"), reason="win only")
  • Uses direct environment variable removal with monkeypatch.delenv() for all four variables (LOGNAME, USER, LNAME, USERNAME) instead of mocking

raise OSError("No username set in the environment")

monkeypatch.setattr(getpass, "getuser", mock_getuser)
assert get_user() is None


class TestNumberedDir:
PREFIX = "fun-"

Expand Down
Loading