fix(pyth-lazer-protocol): deser Channel from String, not &str #2327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| tracing = "0.1" | ||
| url = "2.4" | ||
|
|
||
| [dev_dependencies] |
There was a problem hiding this comment.
what is changed here?
There was a problem hiding this comment.
was it not working at all? or both works?
There was a problem hiding this comment.
both work, but this format is deprecated:
`dev_dependencies` is deprecated in favor of `dev-dependencies` and will not work in the 2024 edition
There was a problem hiding this comment.
it was causing clippy pre-commit step to fail
keyvankhademi
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current deserializer for the Channel type fails to work with string values loaded from toml by config -- the config crate is trying to deserialize an owned
Stringbut the deserializer expects a borrowed&str, causing this error:Fixed by making the deserializer accept both
Stringand&str(Serde will coerce a&strinto aString).Also threw in a minor clippy fix (
dev_dependencies->dev-dependencies).