Skip to content

fix(pyth-lazer-protocol): deser Channel from String, not &str #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(pyth-lazer-protocol): deser Channel from String, not &str #2327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e8a29
fix: deser Channel from String, not &str
tejasbadadare Feb 4, 2025
f8c54d2
fix: bump ver, fix clippy
tejasbadadare Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lazer/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lazer/sdk/rust/client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ anyhow = "1.0"
tracing = "0.1"
url = "2.4"

[dev_dependencies]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is changed here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it not working at all? or both works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both work, but this format is deprecated:

`dev_dependencies` is deprecated in favor of `dev-dependencies` and will not work in the 2024 edition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was causing clippy pre-commit step to fail

[dev-dependencies]
bincode = "1.3.3"
ed25519-dalek = { version = "2.1.1", features = ["rand_core"] }
hex = "0.4.3"
Expand Down
2 changes: 1 addition & 1 deletion lazer/sdk/rust/protocol/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pyth-lazer-protocol"
version = "0.4.1"
version = "0.4.2"
edition = "2021"
description = "Pyth Lazer SDK - protocol types."
license = "Apache-2.0"
Expand Down
4 changes: 2 additions & 2 deletions lazer/sdk/rust/protocol/src/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ impl<'de> Deserialize<'de> for Channel {
where
D: serde::Deserializer<'de>,
{
let value = <&str>::deserialize(deserializer)?;
parse_channel(value).ok_or_else(|| D::Error::custom("unknown channel"))
let value = <String>::deserialize(deserializer)?;
parse_channel(&value).ok_or_else(|| D::Error::custom("unknown channel"))
}
}

Expand Down
Loading