feat: add trademark disclaimer link to footer and disclaimer card to price feeds page #2451
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=80&v=4){kind=small}
…price feeds page Co-Authored-By: Connor Prussin <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
| display: flex; | ||
| flex-flow: column nowrap; | ||
| gap: theme.spacing(4); | ||
| color: theme.color("text"); |
There was a problem hiding this comment.
Please use "foreground" as the color token here instead of "text"
| /> | ||
| </UnstyledTabPanel> | ||
| </UnstyledTabs> | ||
| <div className={styles.trademarkDisclaimerSection}> |
There was a problem hiding this comment.
We don't need a div wrapping the card, just pass the styles.trademarkDisclaimerSection class to the className prop in the Card component.
While you're at it, please rename styles.trademarkDisclaimerSection to styles.trademarkDisclaimerCard
Co-Authored-By: Connor Prussin <[email protected]>
Co-Authored-By: Connor Prussin <[email protected]>
| <p> | ||
| The Pyth Network name, logo, and all related names, logos, product | ||
| and service names, designs, and slogans are trademarks of the Pyth | ||
| Data Association or its affiliates or licensors. |
There was a problem hiding this comment.
Please replace this text with the full contents of https://www.pyth.network/trademark-disclaimer
| target="_blank" | ||
| > | ||
| View Full Disclaimer | ||
| </Button> |
There was a problem hiding this comment.
Please remove this button
| </UnstyledTabs> | ||
| <Card | ||
| className={styles.trademarkDisclaimerCard} | ||
| variant="tertiary" |
There was a problem hiding this comment.
Let's remove this line to make the card use the default variant
Co-Authored-By: Connor Prussin <[email protected]>
Co-Authored-By: Connor Prussin <[email protected]>
Co-Authored-By: Connor Prussin <[email protected]>
| <Card | ||
| className={styles.trademarkDisclaimerCard} | ||
| title="Trademark Disclaimer" | ||
| > |
There was a problem hiding this comment.
This does not look good as a card, so let's remove the Card component wrapping this.
Instead, please add a header that says "Trademark Disclaimer" inside the div with the trademarkDisclaimerContent class. Give the header text a bit larger size, and some space between it and the paragraph.
Co-Authored-By: Connor Prussin <[email protected]>
| /> | ||
| </UnstyledTabPanel> | ||
| </UnstyledTabs> | ||
| <div className={styles.trademarkDisclaimerCard}> |
There was a problem hiding this comment.
We don't need this wrapper div, please remove it.
| </UnstyledTabPanel> | ||
| </UnstyledTabs> | ||
| <div className={styles.trademarkDisclaimerCard}> | ||
| <div className={styles.trademarkDisclaimerContent}> |
There was a problem hiding this comment.
Please rename this class to trademarkDisclaimer
Co-Authored-By: Connor Prussin <[email protected]>
1 participant
Add Trademark Disclaimer Link to Footer and Disclaimer Card to Price Feeds Page
This PR adds:
Changes
Link to Devin run: https://app.devin.ai/sessions/1c543bcf708545b18729337de1077bdc
Requested by: Connor