Skip to content

feat: add trademark disclaimer link to footer and disclaimer card to price feeds page #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 7, 2025
Merged

feat: add trademark disclaimer link to footer and disclaimer card to price feeds page #2451

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7750fa2
feat: add trademark disclaimer link to footer and disclaimer card to …
devin-ai-integration[bot] Mar 6, 2025
08ec7f5
fix: address PR feedback on trademark disclaimer implementation
devin-ai-integration[bot] Mar 6, 2025
f3b10c9
fix: fix formatting issues in PriceFeeds/index.tsx
devin-ai-integration[bot] Mar 6, 2025
e420467
fix: address additional PR feedback on trademark disclaimer
devin-ai-integration[bot] Mar 6, 2025
7f58cd0
fix: escape quotes in trademark disclaimer text to fix ESLint errors
devin-ai-integration[bot] Mar 6, 2025
656ca8c
fix: fix formatting issues in PriceFeeds/index.tsx
devin-ai-integration[bot] Mar 6, 2025
5cb502b
fix: replace Card with div and add header for trademark disclaimer
devin-ai-integration[bot] Mar 7, 2025
1b38c59
fix: rename class to trademarkDisclaimer and remove wrapper div
devin-ai-integration[bot] Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions apps/insights/src/components/PriceFeeds/index.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,20 @@
@include theme.max-width;
}
}

.trademarkDisclaimerCard {
margin-top: theme.spacing(6);
width: 100%;

@include theme.max-width;

.trademarkDisclaimerContent {
padding: theme.spacing(4);
display: flex;
flex-flow: column nowrap;
gap: theme.spacing(4);
color: theme.color("foreground");
font-size: theme.font-size("sm");
}
}
}
23 changes: 23 additions & 0 deletions apps/insights/src/components/PriceFeeds/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,29 @@ export const PriceFeeds = async () => {
/>
</UnstyledTabPanel>
</UnstyledTabs>
<Card
className={styles.trademarkDisclaimerCard}
variant="tertiary"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this line to make the card use the default variant

title="Trademark Disclaimer"
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look good as a card, so let's remove the Card component wrapping this.

Instead, please add a header that says "Trademark Disclaimer" inside the div with the trademarkDisclaimerContent class. Give the header text a bit larger size, and some space between it and the paragraph.

<div className={styles.trademarkDisclaimerContent}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this class to trademarkDisclaimer

<p>
The Pyth Network name, logo, and all related names, logos, product
and service names, designs, and slogans are trademarks of the Pyth
Data Association or its affiliates or licensors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this text with the full contents of https://www.pyth.network/trademark-disclaimer

</p>
<p>
<Button
variant="outline"
size="sm"
href="https://www.pyth.network/trademark-disclaimer"
target="_blank"
>
View Full Disclaimer
</Button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this button

</p>
</div>
</Card>
</div>
);
};
Expand Down
6 changes: 6 additions & 0 deletions apps/insights/src/components/Root/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ export const Footer = () => (
<Link href="https://www.pyth.network/terms-of-use" target="_blank">
Terms of Use
</Link>
<Link
href="https://www.pyth.network/trademark-disclaimer"
target="_blank"
>
Trademark Disclaimer
</Link>
</div>
</div>
</footer>
Expand Down
Loading