Skip to content

pulse-scheduler: init ethereum contracts, subscriptions, updating prices #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 15, 2025
Merged

pulse-scheduler: init ethereum contracts, subscriptions, updating prices #2572

merged 8 commits into from
Apr 15, 2025

Conversation

@tejasbadadare
Copy link
Contributor

@tejasbadadare tejasbadadare commented Apr 9, 2025 •
edited
Loading

Summary

Initialize the Pulse Scheduler Ethereum contracts with a base layer of functionality. Follows the structure/boilerplate of the existing Pulse contracts.

Rationale

Add state, functions, and tests for:

  • Subscription management
    • Only manager can CRUD subscriptions
  • Pushing and consuming price updates
    • An update to a subscription's feeds must have matching timestamps and contain all price IDs for that subscription.
    • Since we plan to make updating permissionless, an update is only allowed if the update criteria is met.
    • Only whitelisted readers can consume the price feeds.
  • Viewing active subscriptions (for keepers)

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Up next

  • Balance management (actually using manager funds)
  • Keeper/provider management (payment/registration, etc)
  • Gas strategy configuration
  • Gas benchmark tests

@vercel
Copy link

vercel bot commented Apr 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 4:46pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 4:46pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 4:46pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 4:46pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 4:46pm
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 4:46pm

@tejasbadadare tejasbadadare changed the title Tb/pulse scheduler/init pulse-scheduler: init ethereum contracts Apr 9, 2025
@tejasbadadare tejasbadadare changed the title pulse-scheduler: init ethereum contracts pulse-scheduler: init ethereum contracts, subscriptions, updating prices Apr 9, 2025
@tejasbadadare
fix: access control, add todos
7605555
@tejasbadadare
feat(scheduler): enhance price update logic and validation
50b341f 
- Updated price feed parsing to allow for a timestamp range of [-10s, now].
- Introduced validation for update conditions, including checks for heartbeat and price deviation.
- Added new error handling for outdated timestamps and unmet update conditions.
- Refactored subscription status to use a uint256 for last updated timestamp.
- Expanded test coverage for update conditions and validation scenarios.
@tejasbadadare
Merge branch 'main' of github.com:pyth-network/pyth-crosschain into t…
800e1ef 
…b/pulse-scheduler/init
jayantk
jayantk approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good start to me. Feel free to address my comments in follow up PRs, as this is pretty big and it's generally fine to merge as is.

Please do let @ali-bahjati take a look before merging though.

@tejasbadadare tejasbadadare mentioned this pull request Apr 15, 2025
Merged
3 tasks
@tejasbadadare
Copy link
Contributor Author

@jayantk addressed your comments in #2585 , @ali-bahjati i'll probably make a new PR to address your feedback since it's already sizable and covers a bunch of disjoint changes

ali-behjati
ali-behjati approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! looking forward to the subsequent prs.

@tejasbadadare tejasbadadare merged commit 59ea3c8 into main Apr 15, 2025
10 checks passed
@tejasbadadare tejasbadadare deleted the tb/pulse-scheduler/init branch April 15, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayantk jayantk jayantk approved these changes

@ali-behjati ali-behjati ali-behjati approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tejasbadadare @jayantk @ali-behjati