feat(pulse-scheduler): address initial comments, update sub management, enforce mininum balance #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated price feed parsing to allow for a timestamp range of [-10s, now]. - Introduced validation for update conditions, including checks for heartbeat and price deviation. - Added new error handling for outdated timestamps and unmet update conditions. - Refactored subscription status to use a uint256 for last updated timestamp. - Expanded test coverage for update conditions and validation scenarios.
…b/pulse-scheduler/init
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
3 tasks
ali-behjati
approved these changes
Apr 15, 2025
target_chains/ethereum/contracts/contracts/pulse/scheduler/IScheduler.sol
Show resolved
Hide resolved
target_chains/ethereum/contracts/contracts/pulse/scheduler/Scheduler.sol
Show resolved
Hide resolved
target_chains/ethereum/contracts/contracts/pulse/scheduler/Scheduler.sol
Show resolved
Hide resolved
target_chains/ethereum/contracts/contracts/pulse/scheduler/SchedulerState.sol
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Rationale
Various improvements from PR and design doc review.
Address PR review comments from pulse-scheduler: init ethereum contracts, subscriptions, updating prices #2572
Match IPyth signatures for the read prices functions (e.g.
getPricesUnsafe) to make migration easier for usersMake deactivateSubscription a special case of updateSubscription
updateSubscriptionto handle activating and deactivating subscriptions makes it possible to reactivate a subscription. This is better UX, since the user may want to pause and resume a subscription without modifying its balance or params.Enforce a minimum balance for active subscriptions
isActivehas moved fromSubscriptionStatustoSubscriptionParamsRemove the
onlyPushermodifier since we will allow anyone to push updates.Update GasConfig to expose
maxGasMultiplierCapPctandmaxFeeMultiplierCapPctcontrols to the user. Set defaults to be very high, since most users would rather land txs at a higher cost than not land them due to limits set too low.How has this been tested?