chore(entropy v2): requestv2 comment fix #2952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nidhi-singh02 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
nidhi-singh02
changed the title
aditya520
requested changes
Aug 13, 2025
| /// `entropyCallback` will be run with the `gasLimit` provided to this function. | ||
| /// The `gasLimit` will be rounded up to a multiple of 10k (e.g., 19000 -> 20000), and furthermore is lower bounded | ||
| /// by the provider's configured default limit. | ||
| /// `entropyCallback` will be run with the provider's configured default gas limit. |
Member
There was a problem hiding this comment.
entropyCallback will be run with the requestor's configured gasLimit. If the request was made without a gasLimit, provider's default gas limit will be used..
Contributor
Author
There was a problem hiding this comment.
Specifically in this function call, we are not taking any gasLimit as input. I am wondering we still need to mention the first line ?
Contributor
There was a problem hiding this comment.
Yeah "will be run with the provider's configured default gas limit" LGTM
Contributor
Author
There was a problem hiding this comment.
Thanks Tejas, keeping it as is.
aditya520
approved these changes
Aug 13, 2025
tejasbadadare
approved these changes
Aug 13, 2025
| /// `entropyCallback` will be run with the `gasLimit` provided to this function. | ||
| /// The `gasLimit` will be rounded up to a multiple of 10k (e.g., 19000 -> 20000), and furthermore is lower bounded | ||
| /// by the provider's configured default limit. | ||
| /// `entropyCallback` will be run with the provider's configured default gas limit. |
Contributor
There was a problem hiding this comment.
Yeah "will be run with the provider's configured default gas limit" LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
requestv2()has a comment which needs to be rectified as this function does not take any input parameter of gasLimit.Rationale
The comment is confusing as there is no
gasLimitprovided.How has this been tested?