Skip to content

chore(entropy v2): requestv2 comment fix #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

chore(entropy v2): requestv2 comment fix #2952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions target_chains/ethereum/entropy_sdk/solidity/IEntropyV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ interface IEntropyV2 is EntropyEventsV2 {
/// The `entropyCallback` method on that interface will receive a callback with the returned sequence number and
/// the generated random number.
///
/// `entropyCallback` will be run with the `gasLimit` provided to this function.
/// The `gasLimit` will be rounded up to a multiple of 10k (e.g., 19000 -> 20000), and furthermore is lower bounded
/// by the provider's configured default limit.
/// `entropyCallback` will be run with the provider's configured default gas limit.
Copy link
Member

@aditya520 aditya520 Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entropyCallback will be run with the requestor's configured gasLimit. If the request was made without a gasLimit, provider's default gas limit will be used..

Copy link
Member

@aditya520 aditya520 Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something around this line.

Copy link
Contributor Author

@nidhi-singh02 nidhi-singh02 Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically in this function call, we are not taking any gasLimit as input. I am wondering we still need to mention the first line ?

Copy link
Contributor

@tejasbadadare tejasbadadare Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah "will be run with the provider's configured default gas limit" LGTM

Copy link
Contributor Author

@nidhi-singh02 nidhi-singh02 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tejas, keeping it as is.

///
/// This method will revert unless the caller provides a sufficient fee (at least `getFeeV2()`) as msg.value.
/// Note that the fee can change over time. Callers of this method should explicitly compute `getFeeV2()`
Expand Down
Loading