fix(insights): remove suspense from SearchButton

[alexcambose]

Summary

Removed Suspense from extraCta to fix server boundary crash in header. This does fix the error but it's not super optimal as we're loosing the <SearchButtonImpl isLoading /> state.

Rationale

I think the issue is that Nextjs can’t stream Suspense data inside props passed to a Client Component;

  <AppShell (client)
    ...
    extraCta={
      <Suspense fallback={<SearchButtonImpl isLoading />}>
        <SearchButton />
      </Suspense>
    }
  >
    {children}
  </AppShell>

And it throws The server could not finish this Suspense boundary, likely due to an error during server rendering. Switched to client rendering.

Another possible way to fix this would be to just fetch the data on the client side with useState/useEffect.

Tried a few other ways, but couldn't really get it to either work or not throw the same error.

How has this been tested?

• Current tests cover my changes
• Added new tests
• Manually tested the code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
api-reference	Ready	Preview	Comment	Aug 18, 2025 10:56am
component-library	Ready	Preview	Comment	Aug 18, 2025 10:56am
developer-hub	Ready	Preview	Comment	Aug 18, 2025 10:56am
entropy-explorer	Ready	Preview	Comment	Aug 18, 2025 10:56am
insights	Ready	Preview	Comment	Aug 18, 2025 10:56am
proposals	Ready	Preview	Comment	Aug 18, 2025 10:56am
staking	Ready	Preview	Comment	Aug 18, 2025 10:56am

[cprussin]

I'm not sure but I think this will cause more perf issues because it means that all pages will have to delay for the async stuff in <SearchButton> before rendering the layout.

@alexcambose I suggest you first merge your perf improvements PR, then rebase this on top and do some testing to ensure it doesn't cause more perf issues.

We might have to think of another way to implement the global search if we can't use suspense.

[alexcambose]

@cprussin I agree. Do you think it would make sense to statically fetch/generate the data at build time and then inject it into these components? Wondering how often things will change in relation to the search.

[alexcambose]

Tested some more and somehow it doesn't seem to add any additional latency even without Suspense.

[cprussin]

Tested some more and somehow it doesn't seem to add any additional latency even without Suspense.

lol ok, that's surprising but maybe just due to the added redis caching... let's ship it!

[alexcambose]

This is one of the "I have no idea how it works but it works"