Skip to content

fix(insights): remove suspense from SearchButton #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

fix(insights): remove suspense from SearchButton #2957

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80e1eda
fix(insights): remove suspense from props
alexcambose Aug 17, 2025
b3f9c31
fix: formatting
alexcambose Aug 17, 2025
9c27269
Merge branch 'main' into fix/suspense-props
alexcambose Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions apps/insights/src/components/Root/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { AppShell } from "@pythnetwork/component-library/AppShell";
import { lookup as lookupPublisher } from "@pythnetwork/known-publishers";
import { NuqsAdapter } from "nuqs/adapters/next/app";
import type { ReactNode } from "react";
import { Suspense } from "react";

import {
ENABLE_ACCESSIBILITY_REPORTING,
Expand Down Expand Up @@ -34,11 +33,7 @@ export const Root = ({ children }: Props) => (
enableAccessibilityReporting={ENABLE_ACCESSIBILITY_REPORTING}
providers={[NuqsAdapter, LivePriceDataProvider]}
tabs={TABS}
extraCta={
<Suspense fallback={<SearchButtonImpl isLoading />}>
<SearchButton />
</Suspense>
}
extraCta={<SearchButton />}
>
{children}
</AppShell>
Expand Down
Loading