feat(insights): omit icon when an asset class has no icon #2975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we display the Generic icon from the cryptocurrency icons set when we have an asset class which no associated icon. However, that icon really doesn't make sense for asset classes that aren't cryptos, so instead this PR just blanks out the icon for such cases.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
alexcambose
approved these changes
Aug 20, 2025
cprussin
deleted the
cprussin/dont-use-generic-icon-for-unmatched-asset-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we display the Generic icon from the cryptocurrency icons set when we have an asset class which no associated icon. However, that icon really doesn't make sense for asset classes that aren't cryptos, so instead this PR just blanks out the icon for such cases.