Skip to content

feat(insights): omit icon when an asset class has no icon #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

feat(insights): omit icon when an asset class has no icon #2975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions apps/insights/src/components/PriceFeedIcon/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import Generic from "cryptocurrency-icons/svg/color/generic.svg";
import type { ComponentProps, ComponentType } from "react";

import Commodities from "./commodities.svg";
Expand Down Expand Up @@ -26,17 +25,22 @@ export const PriceFeedIcon = ({ assetClass, symbol, ...props }: Props) => {
return Icon ? (
<Icon width="100%" height="100%" viewBox="0 0 32 32" {...props} />
) : (
<GenericIcon assetClass={assetClass} {...props} />
<GenericIcon assetClass="Crypto" {...props} />
);
} else {
return <GenericIcon assetClass={assetClass} {...props} />;
return assetClassHasIcon(assetClass) ? (
<GenericIcon assetClass={assetClass} {...props} />
) : // eslint-disable-next-line unicorn/no-null
null;
}
};

type GenericProps = ComponentProps<"svg"> & { assetClass: string };
type GenericProps = ComponentProps<"svg"> & {
assetClass: keyof typeof ASSET_CLASS_TO_ICON;
};

const GenericIcon = ({ assetClass, ...props }: GenericProps) => {
const Icon = ASSET_CLASS_TO_ICON[assetClass] ?? Generic;
const Icon = ASSET_CLASS_TO_ICON[assetClass];
return (
<Icon
width="100%"
Expand All @@ -55,7 +59,7 @@ type SVGProps = ComponentProps<"svg">;
type SVGComponent = ComponentType<SVGProps>;
type SVGRecord = Record<string, SVGComponent>;

const ASSET_CLASS_TO_ICON: Record<string, SVGComponent> = {
const ASSET_CLASS_TO_ICON = {
Commodities,
"Crypto Index": CryptoIndex,
"Crypto Redemption Rate": CryptoRedemptionRate,
Expand All @@ -64,4 +68,9 @@ const ASSET_CLASS_TO_ICON: Record<string, SVGComponent> = {
FX: Fx,
Metal,
Rates,
};
} as const;

const assetClassHasIcon = (
assetClass: string,
): assetClass is keyof typeof ASSET_CLASS_TO_ICON =>
Object.keys(ASSET_CLASS_TO_ICON).includes(assetClass);
Loading