-
Notifications
You must be signed in to change notification settings - Fork 308
feat(developer-hub): add how to guides for express relay #3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
| import { IntegrationCard } from "../../../src/components/IntegrationCard"; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we wanna import the component where we are using
| // This method will revert unless the caller provides a sufficient fee (at least getFee(provider)) as msg.value. | ||
| // Note that excess value is *not* refunded to the caller. | ||
| function request(address provider, bytes32 userCommitment, bool useBlockHash) | ||
| external | ||
| payable | ||
| returns (uint64 assignedSequenceNumber); | ||
| function request( | ||
| address provider, | ||
| bytes32 userCommitment, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is edited as a result of formatting fix, as the CI was failing
| Callout: InfoBox, | ||
| IntegrationCard, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed from here.
| <svg fill="none" stroke="currentColor" viewBox="0 0 24 24"> | ||
| <path | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| strokeWidth={2} | ||
| d="M10 20l4-16m4 4l4 4-4 4M6 16l-4-4 4-4" | ||
| /> | ||
| </svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using an icon pack, we have phosphor-icons, eg:
import {
CardsThree,
} from "@phosphor-icons/react/dist/ssr";
or if the icon is not there, it would be best to export it from a dedicated file so it's easier to know what the svg is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing suggestion. Used the equivalent icon Code in this case from "@phosphor-icons/react/dist/ssr";
Replaced the icons in the Introduction page of express relay as well. The code looks much clean. Thank you @alexcambose
Summary
add how to guides for express relay from documentation
Rationale
How has this been tested?