Skip to content

Conversation

@nidhi-singh02
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 commented Sep 4, 2025

Summary

add how to guides for express relay from documentation

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
component-library Ready Ready Preview Comment Sep 4, 2025 4:07pm
developer-hub Ready Ready Preview Comment Sep 4, 2025 4:07pm
5 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Skipped Skipped Sep 4, 2025 4:07pm
entropy-explorer Skipped Skipped Sep 4, 2025 4:07pm
insights Skipped Skipped Sep 4, 2025 4:07pm
proposals Skipped Skipped Sep 4, 2025 4:07pm
staking Skipped Skipped Sep 4, 2025 4:07pm

Comment on lines 9 to 10
import { IntegrationCard } from "../../../src/components/IntegrationCard";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we wanna import the component where we are using

Comment on lines 46 to +50
// This method will revert unless the caller provides a sufficient fee (at least getFee(provider)) as msg.value.
// Note that excess value is *not* refunded to the caller.
function request(address provider, bytes32 userCommitment, bool useBlockHash)
external
payable
returns (uint64 assignedSequenceNumber);
function request(
address provider,
bytes32 userCommitment,
Copy link
Contributor Author

@nidhi-singh02 nidhi-singh02 Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is edited as a result of formatting fix, as the CI was failing

Comment on lines 14 to -17
Callout: InfoBox,
IntegrationCard,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed from here.

Comment on lines 78 to 85
<svg fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth={2}
d="M10 20l4-16m4 4l4 4-4 4M6 16l-4-4 4-4"
/>
</svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using an icon pack, we have phosphor-icons, eg:

import {
  CardsThree,
} from "@phosphor-icons/react/dist/ssr";

or if the icon is not there, it would be best to export it from a dedicated file so it's easier to know what the svg is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing suggestion. Used the equivalent icon Code in this case from "@phosphor-icons/react/dist/ssr";

Replaced the icons in the Introduction page of express relay as well. The code looks much clean. Thank you @alexcambose

@nidhi-singh02 nidhi-singh02 merged commit 48bee12 into main Sep 4, 2025
10 checks passed
@nidhi-singh02 nidhi-singh02 deleted the add-express-relay-guides branch September 4, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants