Wheels CI: Check number of expected dists #9239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing run: https://github.com/python-pillow/Pillow/actions/runs/18407980303/job/52459987053?pr=9239 And force pushed with the correct number for it to pass. |
radarhere
reviewed
Oct 11, 2025
…139) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Andrew Murray <[email protected]>
|
Updated to require 
https://github.com/python-pillow/Pillow/actions/runs/18428446075?pr=9239 |
radarhere
approved these changes
Oct 11, 2025
This was referenced Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes changes to cibuildwheel (such as #9059) change the defaults and more or less wheels are built, and we don't notice until we happen to spot an unnecessary wheel, or someone reports a missing wheel for their system.
This adds a hardcoded number of dists created by the CI (
EXPECTED_DISTS), and fails if it's different to what's actually produced.This is inspired by the coverage.py CI: https://github.com/nedbat/coveragepy/blob/8827634adcfe4a4baf71cf0b3e1cd967cf9b14a2/.github/workflows/publish.yml#L76-L81
To demonstrate, right now it will fail:
https://github.com/python-pillow/Pillow/actions/runs/18407980303/job/52459987053?pr=9239