gh-127389 - fix 'Uops Executed' display in summarize_stats.py #127396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return gc_stats | ||
|
|
||
| def get_optimization_stats(self) -> dict[str, tuple[int, int | None]]: | ||
| def get_optimization_stats(self) -> dict[Doc, tuple[int, int | None]]: |
There was a problem hiding this comment.
This is also unrelated, right?
There was a problem hiding this comment.
I believe it is related, as the fix for the issue is to treat the value returned from this function as a doc and not a str, so it makes the patch clearer
|
All commit authors signed the Contributor License Agreement. |
| ), | ||
| Doc( | ||
| "Uops executed", | ||
| UOPS_EXECUTED_LABEL, |
There was a problem hiding this comment.
Why? It only had two uses.
There was a problem hiding this comment.
For the code to work correctly the 2 instances must match - its not just any string, its used as an identifier.
Is there any con in moving to a const?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 'Uops Executed' display in summarize_stats.py and some type hints
Tools/scripts/summarize_stats.py#127389