Skip to content

Fix type hints in summarize stats #127453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type hints in summarize stats #127453

wants to merge 1 commit into from

Conversation

alonme
Copy link
Contributor

@alonme alonme commented Nov 30, 2024

@ZeroIntensity Fixing type hints in summarize stats

ZeroIntensity
ZeroIntensity approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to consider running mypy as a part of lint on this in the future, but I doubt it's ready for it's aggressiveness, even with this change. LGTM.

@alonme
Copy link
Contributor Author

alonme commented Nov 30, 2024

@ZeroIntensity @mdboom

I think this TODO can also be deleted, can we do it in this PR or should I open another one just for that?

@ZeroIntensity
Copy link
Member

You can open another PR, let's keep this one focused on type hints.

mdboom
mdboom approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

@alonme
Copy link
Contributor Author

alonme commented Dec 2, 2024

LGTM. Thanks for doing this.

Sure,
please also check out #127396

@tomasr8 tomasr8 removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom mdboom approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alonme @ZeroIntensity @mdboom @serhiy-storchaka @tomasr8