Skip to content

Fix type hints in summarize stats #127453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type hints in summarize stats #127453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Tools/scripts/summarize_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def kind_to_text(kind: int, opcode: str):
def is_specializable(self, opcode: str) -> bool:
return "specializable" in self._get_stats_for_opcode(opcode)

def get_specialized_total_counts(self) -> tuple[int, int, int]:
def get_specialized_total_counts(self) -> tuple[int, int, int, int]:
basic = 0
specialized_hits = 0
specialized_misses = 0
Expand Down Expand Up @@ -442,7 +442,7 @@ def get_gc_stats(self) -> list[dict[str, int]]:
gc_stats[gen_n][name] = value
return gc_stats

def get_optimization_stats(self) -> dict[str, tuple[int, int | None]]:
def get_optimization_stats(self) -> dict[Doc, tuple[int, int | None]]:
if "Optimization attempts" not in self._data:
return {}

Expand Down Expand Up @@ -515,7 +515,7 @@ def get_optimization_stats(self) -> dict[str, tuple[int, int | None]]:
),
}

def get_optimizer_stats(self) -> dict[str, tuple[int, int | None]]:
def get_optimizer_stats(self) -> dict[Doc, tuple[int, int | None]]:
attempts = self._data["Optimization optimizer attempts"]
successes = self._data["Optimization optimizer successes"]
no_memory = self._data["Optimization optimizer failure no memory"]
Expand Down Expand Up @@ -1264,7 +1264,7 @@ def iter_optimization_tables(base_stats: Stats, head_stats: Stats | None = None)


def rare_event_section() -> Section:
def calc_rare_event_table(stats: Stats) -> Table:
def calc_rare_event_table(stats: Stats) -> Rows:
DOCS = {
"set class": "Setting an object's class, `obj.__class__ = ...`",
"set bases": "Setting the bases of a class, `cls.__bases__ = ...`",
Expand Down Expand Up @@ -1395,7 +1395,7 @@ def to_markdown(x):
print("Stats gathered on:", date.today(), file=out)


def output_stats(inputs: list[Path], json_output=str | None):
def output_stats(inputs: list[Path], json_output: str | None):
match len(inputs):
case 1:
data = load_raw_data(Path(inputs[0]))
Expand Down
Loading