-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Update fuzzer.c fix proper handling #128339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Usually a PR should correspond to an open issue (by the way, your title should be prefixed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since as the PR body says, we should add a test to trigger it and ensure that the change fixes this issue.
|
cc @picnixz |
|
Fuzzing is not my area of expertise but here are some thoughts: We are fuzzing What I'm actually wondering is whether we should call |
|
I don't understand what the motivation for this PR is. Can you please try explaining it in more detail? What code injection vulnerability do you believe exists? |
|
Closing as there doesn't seem to be any point to this PR? We actually want the unicode error to be caught in order to skip the This "module" is for fuzz testing purposes only. It is expected to only be used within a contained environment being fed procedurally generated arbitrary inputs to uncover issues. If you believe that |
In this PR addresses there could be potential code injection vulnerability in current file in PR changes ensuring proper handling of invalid UTF-8 sequences.