Skip to content

Update fuzzer.c fix proper handling #128339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update fuzzer.c fix proper handling #128339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Modules/_xxtestfuzz/fuzzer.c
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since as the PR body says, we should add a test to trigger it and ensure that the change fixes this issue.

Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,11 @@ static int fuzz_builtin_int(const char* data, size_t size) {
base = -base;
}

PyObject* s = PyUnicode_FromStringAndSize(data, size);
PyObject* s = PyUnicode_DecodeUTF8(data, size, "replace");
if (s == NULL) {
if (PyErr_ExceptionMatches(PyExc_UnicodeDecodeError)) {
PyErr_Clear();
}
return 0;
}

PyObject* l = PyLong_FromUnicodeObject(s, base);
if (l == NULL && PyErr_ExceptionMatches(PyExc_ValueError)) {
PyErr_Clear();
Expand Down
Loading