-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-128438: Use EnvironmentVarGuard for datetimetester.py to manage environment varibales
#130002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unrelated: I noticed that the github number just broke through 13xxxx! 😄 edit: https://github.com/python/cpython/actions/runs/13262366718/job/37021689070?pr=130002 The test failure has unlated with this Request review @Eclips4 sorry to bother. Had a similar change before #129193. Thank you very much! |
Eclips4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Misc/NEWS.d/next/Tests/2025-02-11-19-55-12.gh-issue-128438.ZIAn_5.rst
Outdated
Show resolved
Hide resolved
pganssle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is good, but I think the details need to be tweaked.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again Used context manager. edit: Also need "skip news" label, label check action failed |
|
Thank you @Wulian233! Sorry for the waiting. |
… manage environment varibales (python#130002)
It's easier to use this to manage environment variables
is part of #128439 (comment)
EnvironmentVarGuardin tests instead of manually messing withos.environ#128438