Skip to content

gh-128438: Use EnvironmentVarGuard for datetimetester.py to manage environment varibales #130002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 27, 2025
+15 −12
Merged

gh-128438: Use EnvironmentVarGuard for datetimetester.py to manage environment varibales #130002

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cc57de
Use `EnvironmentVarGuard` for `datetimetester.py` to manage environme…
Wulian233 Feb 11, 2025
ebffc4a
Delete Misc/NEWS.d/next/Tests/2025-02-11-19-55-12.gh-issue-128438.ZIA…
Wulian233 Feb 12, 2025
d9eda29
use context manager
Wulian233 Feb 22, 2025
283758c
finish
Wulian233 Feb 22, 2025
55e7808
classmethod
Wulian233 Feb 22, 2025
e594012
finish
Wulian233 Feb 22, 2025
d474a2a
Merge branch 'main' into datetimetester
pganssle Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 32 additions & 36 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

from test import support
from test.support import is_resource_enabled, ALWAYS_EQ, LARGEST, SMALLEST
from test.support import script_helper, warnings_helper
from test.support import os_helper, script_helper, warnings_helper

import datetime as datetime_module
from datetime import MINYEAR, MAXYEAR
Expand Down Expand Up @@ -6571,42 +6571,38 @@ def test_system_transitions(self):
self.zonename.startswith('right/')):
self.skipTest("Skipping %s" % self.zonename)
tz = self.tz
TZ = os.environ.get('TZ')
os.environ['TZ'] = self.zonename
try:
_time.tzset()
for udt, shift in tz.transitions():
if udt.year >= 2037:
# System support for times around the end of 32-bit time_t
# and later is flaky on many systems.
break
s0 = (udt - datetime(1970, 1, 1)) // SEC
ss = shift // SEC # shift seconds
for x in [-40 * 3600, -20*3600, -1, 0,
ss - 1, ss + 20 * 3600, ss + 40 * 3600]:
s = s0 + x
sdt = datetime.fromtimestamp(s)
tzdt = datetime.fromtimestamp(s, tz).replace(tzinfo=None)
self.assertEquivDatetimes(sdt, tzdt)
s1 = sdt.timestamp()
self.assertEqual(s, s1)
if ss > 0: # gap
# Create local time inside the gap
dt = datetime.fromtimestamp(s0) - shift / 2
ts0 = dt.timestamp()
ts1 = dt.replace(fold=1).timestamp()
self.assertEqual(ts0, s0 + ss / 2)
self.assertEqual(ts1, s0 - ss / 2)
# gh-83861
utc0 = dt.astimezone(timezone.utc)
utc1 = dt.replace(fold=1).astimezone(timezone.utc)
self.assertEqual(utc0, utc1 + timedelta(0, ss))
finally:
if TZ is None:
del os.environ['TZ']
else:
os.environ['TZ'] = TZ
with os_helper.EnvironmentVarGuard() as env:
env.set('TZ', self.zonename)
_time.tzset()
try:
for udt, shift in tz.transitions():
if udt.year >= 2037:
# System support for times around the end of 32-bit time_t
# and later is flaky on many systems.
break
s0 = (udt - datetime(1970, 1, 1)) // SEC
ss = shift // SEC # shift seconds
for x in [-40 * 3600, -20*3600, -1, 0,
ss - 1, ss + 20 * 3600, ss + 40 * 3600]:
s = s0 + x
sdt = datetime.fromtimestamp(s)
tzdt = datetime.fromtimestamp(s, tz).replace(tzinfo=None)
self.assertEquivDatetimes(sdt, tzdt)
s1 = sdt.timestamp()
self.assertEqual(s, s1)
if ss > 0: # gap
# Create local time inside the gap
dt = datetime.fromtimestamp(s0) - shift / 2
ts0 = dt.timestamp()
ts1 = dt.replace(fold=1).timestamp()
self.assertEqual(ts0, s0 + ss / 2)
self.assertEqual(ts1, s0 - ss / 2)
# gh-83861
utc0 = dt.astimezone(timezone.utc)
utc1 = dt.replace(fold=1).astimezone(timezone.utc)
self.assertEqual(utc0, utc1 + timedelta(0, ss))
finally:
_time.tzset()


class ZoneInfoCompleteTest(unittest.TestSuite):
Expand Down
Loading