gh-130736: Fix asyncio test_shutdown_default_executor_timeout() #130800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
added
tests
vstinner
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
I think we should use a |
Replace time.sleep() with threading.Event.
vstinner
force-pushed
the
shutdown_timeout
branch
from
e4ea1cb to
3f59d55
Compare
You're right. I rewrote my PR to use an event instead. |
colesbury
approved these changes
Mar 3, 2025
kumaraditya303
approved these changes
Mar 4, 2025
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 4, 2025
…pythonGH-130800) Replace time.sleep() with threading.Event. (cherry picked from commit 6c48ed7) Co-authored-by: Victor Stinner <[email protected]>
|
GH-130825 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 4, 2025
…pythonGH-130800) Replace time.sleep() with threading.Event. (cherry picked from commit 6c48ed7) Co-authored-by: Victor Stinner <[email protected]>
|
GH-130826 is a backport of this pull request to the 3.12 branch. |
|
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…python#130800) Replace time.sleep() with threading.Event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a ridiculous small timeout (1 nanosecond) instead of 10 ms.
test_shutdown_default_executor_timeoutasyncio test is flaky #130736