Skip to content

gh-130736: Fix asyncio test_shutdown_default_executor_timeout() #130800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

gh-130736: Fix asyncio test_shutdown_default_executor_timeout() #130800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f59d55
gh-130736: Fix asyncio test_shutdown_default_executor_timeout()
vstinner Mar 3, 2025
69a2191
Restore the timeout of 10 ms
vstinner Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions Lib/test/test_asyncio/test_base_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,20 +233,25 @@ def test_set_default_executor_error(self):
self.assertIsNone(self.loop._default_executor)

def test_shutdown_default_executor_timeout(self):
event = threading.Event()

class DummyExecutor(concurrent.futures.ThreadPoolExecutor):
def shutdown(self, wait=True, *, cancel_futures=False):
if wait:
time.sleep(0.1)
event.wait()

self.loop._process_events = mock.Mock()
self.loop._write_to_self = mock.Mock()
executor = DummyExecutor()
self.loop.set_default_executor(executor)

with self.assertWarnsRegex(RuntimeWarning,
"The executor did not finishing joining"):
self.loop.run_until_complete(
self.loop.shutdown_default_executor(timeout=0.01))
try:
with self.assertWarnsRegex(RuntimeWarning,
"The executor did not finishing joining"):
self.loop.run_until_complete(
self.loop.shutdown_default_executor(timeout=0.01))
finally:
event.set()

def test_call_soon(self):
def cb():
Expand Down
Loading