Fixed keywords arguments of subprocess.Popen.__init__ overriding by positional argumens of subprocess.run
#131599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
subprocess.runpasses process arguments tosubprocess.Popen.__init__as vararg,cpython/Lib/subprocess.py
Line 554 in bc26f95
but constructor expects them as single iterable argument,
cpython/Lib/subprocess.py
Lines 813 to 821 in bc26f95
so path to executable gets into
args, first process argument gets intobufsize, second toexecutableand so on.Example programm (tested on 3.8, but seems this part of code still not fixed):
Error:
This PR provides fix of this error, but
subprocess.rundefinition should be reviewed because in source, stubs and docs it has different signature (vararg/position of asterisc).