Skip to content

Fixed keywords arguments of subprocess.Popen.__init__ overriding by positional argumens of subprocess.run #131599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed keywords arguments of subprocess.Popen.__init__ overriding by positional argumens of subprocess.run #131599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b298d6d
Fixed keywords arguments of `subprocess.Popen.__init__` overriding by…
landgrafhomyak Mar 23, 2025
e899ae3
Added backward compatiblity for `popenargs` in `subprocess.run`
landgrafhomyak Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,11 @@ def run(*popenargs,
kwargs['stdout'] = PIPE
kwargs['stderr'] = PIPE

with Popen(*popenargs, **kwargs) as process:
# backward compatibility
if not isinstance(popenargs, os.PathLike) and len(popenargs) == 1:
popenargs = popenargs[0]

with Popen(popenargs, **kwargs) as process:
try:
stdout, stderr = process.communicate(input, timeout=timeout)
except TimeoutExpired as exc:
Expand Down
Loading