[3.13] GH-130673: Gracefully handle missing sections in JIT build (GH-130906) #131749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…honGH-130906) (cherry picked from commit a26a301) Co-authored-by: Bojun Ren <[email protected]>
|
@brandtbucher the tests seem to hang but I don't know how to fix them (well I don't have the time to actually) |
|
I think it's just due to emulation in this particular set of CI jobs. Can somebody add |
|
I'll do it tomorrow! |
|
Hum, it appears that the test suite for the JIT for MSVC entirely fails. Any idea on this? @brandtbucher |
|
The remaining job is just super slow, and exceeds the timeout of 90 minutes. Not because of this PR, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a26a301)
Co-authored-by: Bojun Ren [email protected]