Skip to content

[3.13] GH-130673: Gracefully handle missing sections in JIT build (GH-130906) #131749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

[3.13] GH-130673: Gracefully handle missing sections in JIT build (GH-130906) #131749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2745aa4
GH-130673: Gracefully handle missing sections in JIT build (GH-130906)
rennsax Mar 25, 2025
c6963eb
Merge branch '3.13' into backport-a26a301-3.13
picnixz Apr 5, 2025
0256e98
ignore `test.test_posix.PosixTester.test_fexecve`
picnixz Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2025-03-06-20-55-34.gh-issue-130673.T3RSCI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix potential ``KeyError`` when handling object sections during JIT building
process.
6 changes: 5 additions & 1 deletion Tools/jit/_targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,11 @@ def _handle_section(
if section_type == "SHT_RELA":
assert "SHF_INFO_LINK" in flags, flags
assert not section["Symbols"]
value, base = group.symbols[section["Info"]]
maybe_symbol = group.symbols.get(section["Info"])
if maybe_symbol is None:
# These are relocations for a section we're not emitting. Skip:
return
value, base = maybe_symbol
if value is _stencils.HoleValue.CODE:
stencil = group.code
else:
Expand Down
1 change: 1 addition & 0 deletions Tools/jit/ignore-tests-emulated-linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ test.test_pathlib.PosixPathTest.test_is_mount_root
test.test_pathlib.test_pathlib.PathSubclassTest.test_is_mount_root
test.test_pathlib.test_pathlib.PathTest.test_is_mount_root
test.test_pathlib.test_pathlib.PosixPathTest.test_is_mount_root
test.test_posix.PosixTester.test_fexecve
test.test_posix.TestPosixSpawn.test_close_file
test.test_posix.TestPosixSpawnP.test_close_file
test.test_posixpath.PosixPathTest.test_ismount
Expand Down
Loading