Skip to content

gh-132657: Avoid locking in frozenset.__contains__ #132659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

gh-132657: Avoid locking in frozenset.__contains__ #132659

merged 2 commits into from
Apr 18, 2025

Conversation

@eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Apr 17, 2025 •
edited by bedevere-app bot
Loading

@eendebakpt eendebakpt requested a review from rhettinger as a code owner April 17, 2025 19:36
@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2025
Open
@rhettinger
Copy link
Contributor

To my eyes, the new code looks identical to the existing set___contains___impl.

@eendebakpt
Copy link
Contributor Author

Almost identical, except that the set___contains___impl has an extra line @critical_section. This results in a Py_BEGIN_CRITICAL_SECTION in the clinic generated code.

@kumaraditya303 kumaraditya303 merged commit e77d678 into python:main Apr 18, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@rhettinger rhettinger rhettinger approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eendebakpt @rhettinger @colesbury @kumaraditya303