Skip to content

gh-132657: Avoid locking in frozenset.__contains__ #132659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

gh-132657: Avoid locking in frozenset.__contains__ #132659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e317c72
Avoid locking in frozenset.__contains__
eendebakpt Apr 17, 2025
6903e01
fix build
eendebakpt Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion Objects/clinic/setobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 23 additions & 1 deletion Objects/setobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2253,6 +2253,28 @@ set___contains___impl(PySetObject *so, PyObject *key)
return PyBool_FromLong(result);
}

/*[clinic input]
@coexist
frozenset.__contains__
so: setobject
object as key: object
/

x.__contains__(y) <==> y in x.
[clinic start generated code]*/

static PyObject *
frozenset___contains___impl(PySetObject *so, PyObject *key)
/*[clinic end generated code: output=2301ed91bc3a6dd5 input=2f04922a98d8bab7]*/
{
long result;

result = set_contains_lock_held(so, key);
if (result < 0)
return NULL;
return PyBool_FromLong(result);
}

/*[clinic input]
@critical_section
set.remove
Expand Down Expand Up @@ -2555,7 +2577,7 @@ PyTypeObject PySet_Type = {


static PyMethodDef frozenset_methods[] = {
SET___CONTAINS___METHODDEF
FROZENSET___CONTAINS___METHODDEF
FROZENSET_COPY_METHODDEF
SET_DIFFERENCE_MULTI_METHODDEF
SET_INTERSECTION_MULTI_METHODDEF
Expand Down
Loading