gh-135444: fix DatagramTransport buffer_size accounting #135445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbronder
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
jsbronder
force-pushed
the
dgram-accounting
branch
from
04c6560 to
8a8f749
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
jsbronder
force-pushed
the
dgram-accounting
branch
from
8a8f749 to
860cec6
Compare
jsbronder
added a commit
to jsbronder/asyncio-dgram
that referenced
this pull request
Jul 7, 2025
Accounting in asyncio.DatagramTransport is broken, so this won't pass. python/cpython#135444 python/cpython#135445
jsbronder
added a commit
to jsbronder/asyncio-dgram
that referenced
this pull request
Jul 7, 2025
Accounting in asyncio.DatagramTransport is broken, so this won't pass. python/cpython#135444 python/cpython#135445
kumaraditya303
added
type-bug
Misc/NEWS.d/next/Library/2025-06-16-12-37-02.gh-issue-135444.An2eeA.rst
Outdated
Show resolved
Hide resolved
Commit 73e8637 added 8 to the buffer_size when send could not be called right away. However, it did not complete this accounting by removing 8 from the buffer size when sending did finally complete.
jsbronder
force-pushed
the
dgram-accounting
branch
from
860cec6 to
f661a57
Compare
kumaraditya303
approved these changes
Jul 30, 2025
|
Thanks @jsbronder for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2025
…r datagram header size when data cannot be sent (pythonGH-135445) (cherry picked from commit e3ea861) Co-authored-by: Justin Bronder <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2025
…r datagram header size when data cannot be sent (pythonGH-135445) (cherry picked from commit e3ea861) Co-authored-by: Justin Bronder <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
|
GH-137245 is a backport of this pull request to the 3.14 branch. |
|
GH-137246 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
added a commit
that referenced
this pull request
Aug 3, 2025
…or datagram header size when data cannot be sent (GH-135445) (#137246) gh-135444: fix `asyncio.DatagramTransport.sendto` to account for datagram header size when data cannot be sent (GH-135445) (cherry picked from commit e3ea861) Co-authored-by: Justin Bronder <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…r datagram header size when data cannot be sent (python#135445) Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303
added a commit
that referenced
this pull request
Oct 7, 2025
…or datagram header size when data cannot be sent (GH-135445) (#137245) gh-135444: fix `asyncio.DatagramTransport.sendto` to account for datagram header size when data cannot be sent (GH-135445) (cherry picked from commit e3ea861) Co-authored-by: Justin Bronder <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 73e8637 added 8 to the buffer_size when send could not be called right away. However, it did not complete this accounting by removing 8 from the buffer size when sending did finally complete.