Skip to content

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 21, 2025

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should get a test case, considering there was a small repro in the issue.

@kumaraditya303 kumaraditya303 added needs backport to 3.14 bugs and security fixes type-crash A hard crash of the interpreter, possibly with a core dump 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Aug 22, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit fc0f013 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138027%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 22, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming buildbots pass

@kumaraditya303 kumaraditya303 merged commit b9bcd02 into python:main Aug 22, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@kumaraditya303 kumaraditya303 deleted the shutdown-bug branch August 22, 2025 13:40
@miss-islington-app
Copy link

Sorry, @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b9bcd02e9fe976e0a6a8e8a0b336d598b1d73b13 3.14

@bedevere-app
Copy link

bedevere-app bot commented Aug 22, 2025

GH-138065 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 22, 2025
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Aug 22, 2025
…in runtime shutdown (pythonGH-138027)

(cherry picked from commit b9bcd02)

Co-authored-by: Kumar Aditya <[email protected]>
hugovk pushed a commit that referenced this pull request Aug 22, 2025
kumaraditya303 added a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants