Skip to content

gh-137384: fix warnings finalization order #138027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2025
Merged

gh-137384: fix warnings finalization order #138027

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d544001
fix warnings finalization bug
kumaraditya303 Aug 21, 2025
bfb7d5d
add a test
kumaraditya303 Aug 22, 2025
fc0f013
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 22, 2025
80d0ff8
Update Misc/NEWS.d/next/Core_and_Builtins/2025-08-22-11-39-40.gh-issu…
kumaraditya303 Aug 22, 2025
2384d36
Merge branch 'main' into shutdown-bug
kumaraditya303 Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,6 @@ interpreter_clear(PyInterpreterState *interp, PyThreadState *tstate)
_Py_ClearExecutorDeletionList(interp);
#endif
_PyAST_Fini(interp);
_PyWarnings_Fini(interp);
_PyAtExit_Fini(interp);

// All Python types must be destroyed before the last GC collection. Python
Expand All @@ -815,6 +814,10 @@ interpreter_clear(PyInterpreterState *interp, PyThreadState *tstate)
/* Last garbage collection on this interpreter */
_PyGC_CollectNoFail(tstate);
_PyGC_Fini(interp);

// Finalize warnings after last gc so that any finalizers can
// access warnings state
_PyWarnings_Fini(interp);
struct _PyExecutorObject *cold = interp->cold_executor;
if (cold != NULL) {
interp->cold_executor = NULL;
Expand Down
Loading