gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac #138089

yihong0618 · 2025-08-23T13:58:22Z

for mac if environ is valid and it will retrigger all of it

so I checked the code base in repr the os is from init
so make it in__init__ is better and can avoid

and that is not enough, we also need fix it the same way in

_can_colorize theme

cc @pablogsal

in my env it fixed the issue, and I wonder it maybe a litter faster

Issue: Py313 REPL crash on malformed os.environ #128636

Signed-off-by: yihong0618 <[email protected]>

yihong0618 · 2025-08-23T13:59:09Z

the news is the same so maybe we can ignore it?

Signed-off-by: yihong0618 <[email protected]>

yihong0618 · 2025-08-23T14:10:24Z

Why only 3.13?

only up to 3.13 new repr has this issue follow this patch title #129186

picnixz · 2025-08-23T14:11:05Z

the news is the same so maybe we can ignore it?

No, because we have already shipped a few releases since then, so we need a fresh one.

Lib/_pyrepl/unix_console.py

yihong0618 · 2025-08-23T14:13:09Z

the news is the same so maybe we can ignore it?

No, because we have already shipped a few releases since then, so we need a fresh one.

learned that, thank you very much

picnixz · 2025-08-23T14:13:50Z

only up to 3.13 new repr has this issue follow this patch title #129186

That's the backport. All PRs must first be done against main and we backport them when needed. We only use [3.x] when the fix is specific to the version.

yihong0618 · 2025-08-23T14:16:19Z

only up to 3.13 new repr has this issue follow this patch title #129186

That's the backport. All PRs must first be done against main and we backport them when needed. We only use [3.x] when the fix is specific to the version.

copy that, sorry for my wrong understand at first

Signed-off-by: yihong0618 <[email protected]>

picnixz

I'm not entirely sure but caching THEME() seems to go against the comment in THEME().

Lib/_pyrepl/reader.py

Lib/_pyrepl/unix_console.py

Signed-off-by: yihong0618 <[email protected]>

yihong0618 · 2025-08-23T22:59:09Z

I'm not entirely sure but caching THEME() seems to go against the comment in THEME().

addressed thank you

and add tests

Signed-off-by: yihong0618 <[email protected]>

Lib/test/test_pyrepl/test_unix_console.py

bedevere-app · 2025-08-24T08:17:29Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Signed-off-by: yihong0618 <[email protected]>

…hong0618/cpython into hy/close_issue_128636_for_mac

I'm letting Łukasz shepherd this as I'm not a REPL expert

Lib/_colorize.py

Signed-off-by: yihong0618 <[email protected]>

yihong0618 · 2025-08-25T13:49:48Z

fixed thank you for the help

Lib/test/test_pyrepl/test_unix_console.py

Lib/_colorize.py

Signed-off-by: yihong0618 <[email protected]>

miss-islington-app · 2025-09-15T16:26:58Z

Thanks @yihong0618 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2025-09-15T16:26:58Z

Thanks @yihong0618 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…ith an invalid value for macOS (pythonGH-138089) (cherry picked from commit 8ef7735) Co-authored-by: yihong <[email protected]> Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>

miss-islington-app · 2025-09-15T16:27:07Z

Sorry, @yihong0618 and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8ef7735c536e0ffe4a60224e59b7587288f53e9e 3.13

bedevere-app · 2025-09-15T16:27:12Z

GH-138938 is a backport of this pull request to the 3.14 branch.

…ith an invalid value for macOS (pythonGH-138089) Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]> (cherry picked from commit 8ef7735)

…itten with an invalid value for macOS (pythonGH-138089) (cherry picked from commit 8ef7735) Co-authored-by: yihong <[email protected]> Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>

bedevere-app · 2025-09-15T16:49:01Z

GH-138942 is a backport of this pull request to the 3.13 branch.

…with an invalid value for macOS (GH-138089) (GH-138942) Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]> (cherry picked from commit 8ef7735)

…with an invalid value for macOS (GH-138089) (#138938) Co-authored-by: yihong <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>

fix: close issue python#128636 for mac make is_mac at init

1b8a228

Signed-off-by: yihong0618 <[email protected]>

yihong0618 requested review from ambv, lysnikolaou and pablogsal as code owners August 23, 2025 13:58

bedevere-app bot added the awaiting review label Aug 23, 2025

This was referenced Aug 23, 2025

Py313 REPL crash on malformed os.environ #128636

Closed

gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value #128653

Merged

fix: mypy check issue

ae9d55f

Signed-off-by: yihong0618 <[email protected]>

picnixz changed the title ~~[3.13] gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac(GH-128653)~~ gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac Aug 23, 2025

picnixz reviewed Aug 23, 2025

View reviewed changes

Lib/_pyrepl/unix_console.py Outdated Show resolved Hide resolved

fix: delete copilot tab useless comments

b838c04

Signed-off-by: yihong0618 <[email protected]>

picnixz reviewed Aug 23, 2025

View reviewed changes

Lib/_pyrepl/reader.py Outdated Show resolved Hide resolved

Lib/_pyrepl/unix_console.py Show resolved Hide resolved

fix: address comments

738d41e

Signed-off-by: yihong0618 <[email protected]>

yihong0618 added 3 commits August 24, 2025 10:22

fix: add tests for the change

a0a5cf3

Signed-off-by: yihong0618 <[email protected]>

fix: test is wrong

2e9faf7

Signed-off-by: yihong0618 <[email protected]>

Merge branch 'main' into hy/close_issue_128636_for_mac

3a25033

yihong0618 requested a review from picnixz August 24, 2025 08:12

picnixz previously requested changes Aug 24, 2025

View reviewed changes

Lib/test/test_pyrepl/test_unix_console.py Outdated Show resolved Hide resolved

Lib/test/test_pyrepl/test_unix_console.py Outdated Show resolved Hide resolved

Lib/test/test_pyrepl/test_unix_console.py Outdated Show resolved Hide resolved

bedevere-app bot added awaiting changes and removed awaiting review labels Aug 24, 2025

yihong0618 added 2 commits August 24, 2025 17:17

fix: address review comments

c7cbd22

Signed-off-by: yihong0618 <[email protected]>

Merge branch 'hy/close_issue_128636_for_mac' of https://github.com/yi…

53aa617

…hong0618/cpython into hy/close_issue_128636_for_mac

bedevere-app bot added awaiting review and removed awaiting changes labels Aug 25, 2025

ambv reviewed Aug 25, 2025

View reviewed changes

Lib/_colorize.py Outdated Show resolved Hide resolved

fix: address commnets better way with safe_get

fe34228

Signed-off-by: yihong0618 <[email protected]>

yihong0618 requested a review from ambv August 25, 2025 13:49

hugovk reviewed Aug 25, 2025

View reviewed changes

Lib/test/test_pyrepl/test_unix_console.py Outdated Show resolved Hide resolved

Lib/test/test_pyrepl/test_unix_console.py Outdated Show resolved Hide resolved

Lib/_colorize.py Show resolved Hide resolved

fix: address comments again

3177b0a

Signed-off-by: yihong0618 <[email protected]>

yihong0618 requested a review from hugovk August 25, 2025 20:55

yihong0618 requested a review from picnixz September 3, 2025 14:05

picnixz removed their request for review September 6, 2025 14:40

fix: add news for it

5b6c7b3

Signed-off-by: yihong0618 <[email protected]>

ambv merged commit 8ef7735 into python:main Sep 15, 2025
53 checks passed

bedevere-app bot removed the awaiting review label Sep 15, 2025

ambv added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 15, 2025

miss-islington-app bot assigned ambv Sep 15, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 15, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 15, 2025

Uh oh!

gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac #138089

gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac #138089

Uh oh!

Conversation

yihong0618 commented Aug 23, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yihong0618 commented Aug 23, 2025

Uh oh!

yihong0618 commented Aug 23, 2025

Uh oh!

picnixz commented Aug 23, 2025

Uh oh!

Uh oh!

yihong0618 commented Aug 23, 2025

Uh oh!

picnixz commented Aug 23, 2025

Uh oh!

yihong0618 commented Aug 23, 2025

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yihong0618 commented Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app bot commented Aug 24, 2025

Uh oh!

Uh oh!

yihong0618 commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-app bot commented Sep 15, 2025

Uh oh!

miss-islington-app bot commented Sep 15, 2025

Uh oh!

miss-islington-app bot commented Sep 15, 2025

Uh oh!

bedevere-app bot commented Sep 15, 2025

Uh oh!

bedevere-app bot commented Sep 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yihong0618 commented Aug 23, 2025 •

edited by bedevere-app bot

Loading

yihong0618 commented Aug 23, 2025 •

edited

Loading