-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac #138089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1b8a228
fix: close issue #128636 for mac make is_mac at init
yihong0618 ae9d55f
fix: mypy check issue
yihong0618 b838c04
fix: delete copilot tab useless comments
yihong0618 738d41e
fix: address comments
yihong0618 a0a5cf3
fix: add tests for the change
yihong0618 2e9faf7
fix: test is wrong
yihong0618 3a25033
Merge branch 'main' into hy/close_issue_128636_for_mac
yihong0618 c7cbd22
fix: address review comments
yihong0618 53aa617
Merge branch 'hy/close_issue_128636_for_mac' of https://github.com/yi…
yihong0618 02e8f9d
fix: address comments better test for it
yihong0618 e4acbd0
fix: better way for already colorized
yihong0618 aa37996
fix: mypy check
yihong0618 72867e0
fix: useless code check
yihong0618 fe34228
fix: address commnets better way with safe_get
yihong0618 3177b0a
fix: address comments again
yihong0618 5b6c7b3
fix: add news for it
yihong0618 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2025-09-10-10-02-59.gh-issue-128636.ldRKGZ.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Fix crash in PyREPL when os.environ is overwritten with an invalid value for | ||
mac |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.