-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-138192: Fix Context initialization so that all subinterpreters are assigned the MISSING value. #138503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rs are assigned the MISSING value.
| return _PyStatus_OK(); | ||
| } | ||
|
|
||
| PyObject *missing = get_token_missing(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_token_missing is using Singleton value so it is safe to use.
|
FYI, I locally checked that refleak tests are passed. |
Misc/NEWS.d/next/Core_and_Builtins/2025-09-05-01-19-04.gh-issue-138192.erluq5.rst
Outdated
Show resolved
Hide resolved
…e-138192.erluq5.rst Co-authored-by: Peter Bierma <[email protected]>
|
@ZeroIntensity Would you like to take a look again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me.
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…rs are assigned the MISSING value. (pythongh-138503) --------- (cherry picked from commit f070f54) Co-authored-by: Donghee Na <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
|
GH-138505 is a backport of this pull request to the 3.14 branch. |
…ers are assigned the MISSING value. (gh-138503) (#138505) Co-authored-by: Donghee Na <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
|
…erpreters are assigned the MISSING value. (pythongh-138503) (python#138505) Co-authored-by: Donghee Na <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
…rs are assigned the MISSING value. (pythongh-138503) --------- Co-authored-by: Peter Bierma <[email protected]>
contextvars.Token.MISSINGattribute not available in subinterpreters #138192