-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-138192: Fix Context initialization so that all subinterpreters are assigned the MISSING value. #138503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
gh-138192: Fix Context initialization so that all subinterpreters are assigned the MISSING value. #138503
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7c6681b
gh-138192: Fix Context initialization so that all subinterpreters are…
corona10 c2ce013
update
corona10 ea59d12
Update Misc/NEWS.d/next/Core_and_Builtins/2025-09-05-01-19-04.gh-issu…
corona10 30aed72
Add assertion
corona10 edf6db4
Update
corona10 d8e900d
nit
corona10 9a925e6
Update
corona10 16073a0
Update
corona10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core_and_Builtins/2025-09-05-01-19-04.gh-issue-138192.erluq5.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Fix Context initialization so that all subinterpreters are assigned the | ||
| MISSING value. | ||
corona10 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1360,10 +1360,6 @@ get_token_missing(void) | |
| PyStatus | ||
| _PyContext_Init(PyInterpreterState *interp) | ||
| { | ||
| if (!_Py_IsMainInterpreter(interp)) { | ||
| return _PyStatus_OK(); | ||
| } | ||
|
|
||
| PyObject *missing = get_token_missing(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. get_token_missing is using Singleton value so it is safe to use.
corona10 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (PyDict_SetItemString( | ||
| _PyType_GetDict(&PyContextToken_Type), "MISSING", missing)) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.