-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-137638: Use macos-15-intel in GitHub Actions #139154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+10
−21
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
30e800a
run x86 builds under rosetta
JacobCoffee e730b34
Merge branch 'main' into jit-rosetta-x86
JacobCoffee f77509a
bump to new macos 15 intel runner
JacobCoffee ad2d480
oopsie
JacobCoffee a673930
apply code review requests
JacobCoffee 886dc69
Merge branch 'main' into jit-rosetta-x86
JacobCoffee b181149
try removing find fix
JacobCoffee b36ac07
Update build.yml
JacobCoffee 46a4d50
Update build.yml
JacobCoffee a240580
Apply suggestion from @webknjaz
JacobCoffee 9c075fa
Apply suggestions from code review
JacobCoffee cdd5df9
Merge branch 'main' into jit-rosetta-x86
JacobCoffee 2dce428
Mention other pending issue
hugovk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ jobs: | |
runner: windows-11-arm | ||
- target: x86_64-apple-darwin/clang | ||
architecture: x86_64 | ||
runner: macos-13 | ||
runner: macos-15-intel | ||
- target: aarch64-apple-darwin/clang | ||
architecture: aarch64 | ||
runner: macos-14 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe update arm runners to 15 in a separate follow-up PR (since this one is declared to be about handling intel) |
||
|
@@ -106,15 +106,10 @@ jobs: | |
./PCbuild/build.bat --experimental-jit ${{ matrix.debug && '-d' || '' }} -p ${{ matrix.architecture }} | ||
./PCbuild/rt.bat ${{ matrix.debug && '-d' || '' }} -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3 | ||
|
||
# The `find` line is required as a result of https://github.com/actions/runner-images/issues/9966. | ||
# This is a bug in the macOS runner image where the pre-installed Python is installed in the same | ||
# directory as the Homebrew Python, which causes the build to fail for macos-13. This line removes | ||
# the symlink to the pre-installed Python so that the Homebrew Python is used instead. | ||
- name: macOS | ||
if: runner.os == 'macOS' | ||
run: | | ||
brew update | ||
find /usr/local/bin -lname '*/Library/Frameworks/Python.framework/*' -delete | ||
brew install llvm@${{ matrix.llvm }} | ||
export SDKROOT="$(xcrun --show-sdk-path)" | ||
# Set MACOSX_DEPLOYMENT_TARGET and -Werror=unguarded-availability to | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,15 +60,15 @@ jobs: | |
--prefix=/opt/python-dev \ | ||
--with-openssl="$(brew --prefix [email protected])" | ||
- name: Build CPython | ||
if : ${{ inputs.free-threading || inputs.os != 'macos-13' }} | ||
if : ${{ inputs.free-threading || inputs.os != 'macos-15-intel' }} | ||
run: gmake -j8 | ||
- name: Build CPython for compiler warning check | ||
if : ${{ !inputs.free-threading && inputs.os == 'macos-13' }} | ||
if : ${{ !inputs.free-threading && inputs.os == 'macos-15-intel' }} | ||
run: set -o pipefail; gmake -j8 --output-sync 2>&1 | tee compiler_output_macos.txt | ||
- name: Display build info | ||
run: make pythoninfo | ||
- name: Check compiler warnings | ||
if : ${{ !inputs.free-threading && inputs.os == 'macos-13' }} | ||
if : ${{ !inputs.free-threading && inputs.os == 'macos-15-intel' }} | ||
run: >- | ||
python3 Tools/build/check_warnings.py | ||
--compiler-output-file-path=compiler_output_macos.txt | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.