-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-137638: Use macos-15-intel in GitHub Actions #139154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that GitHub is supporting macOS Intel until Fall 2027, I think we can just bump to the macos-15 runner image instead of using emulation.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Lint error:
To fix, add cpython/.github/actionlint.yaml Lines 1 to 3 in 872eafd
And reference rhysd/actionlint#571. (It's been fixed in rhysd/actionlint#572 but pending release.) Please could you also update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm assuming that you'll update the other actions as part of this PR, so I'll hold off on merging unless you tell me otherwise.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@JacobCoffee perhaps link actions/runner-images#13045 or some other announcements in the PR description for context? Looks like GH sent out an email blast about this just a couple hours ago. |
runner: macos-15-intel | ||
- target: aarch64-apple-darwin/clang | ||
architecture: aarch64 | ||
runner: macos-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe update arm runners to 15 in a separate follow-up PR (since this one is declared to be about handling intel)
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @JacobCoffee for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14. |
(cherry picked from commit 1ae9250) Co-authored-by: Jacob Coffee <[email protected]> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sorry, @JacobCoffee and @hugovk, I could not cleanly backport this to
|
Sorry, @JacobCoffee and @hugovk, I could not cleanly backport this to
|
GH-139545 is a backport of this pull request to the 3.14 branch. |
Sorry, @JacobCoffee and @hugovk, I could not cleanly backport this to
|
Sorry, @JacobCoffee and @hugovk, I could not cleanly backport this to
|
…139545) Co-authored-by: Jacob Coffee <[email protected]> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
Fixes #137638
macos-13
@ GHA by Sep 1, 2025 #137638