gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()
#139396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Ok, I'm proposing to remove that note from the 'A new type of interpreter' section, and I've also made the A |
Wulian233
changed the title
AA-Turner
changed the title
SOURCE_DATE_EPOCH support in ZipFile.writestr()
Contributor
Author
Finished, thank you! |
AA-Turner
requested changes
Oct 4, 2025
Doc/library/zipfile.rst
Outdated
Comment on lines
529
to
530
| .. versionchanged:: 3.14 | ||
| Now respects :envvar:`SOURCE_DATE_EPOCH` environment variable. |
Member
There was a problem hiding this comment.
I think the text can be improved here. The sentence lacks an object, but more importantly we don't say what has actually changed in the method's behaviour if SDE is set.
A
AA-Turner
changed the title
SOURCE_DATE_EPOCH support in ZipFile.writestr()SOURCE_DATE_EPOCH support in ZipFile.writestr()
Contributor
Author
|
Ping @AA-Turner |
vstinner
changed the title
SOURCE_DATE_EPOCH support in ZipFile.writestr()SOURCE_DATE_EPOCH support in ZipFile.writestr()
vstinner
reviewed
Nov 4, 2025
Co-authored-by: Victor Stinner <[email protected]>
vstinner
approved these changes
Nov 4, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but English is not my first language, so I'm not sure about the sentence :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.