Skip to content

Note SOURCE_DATE_EPOCH support in ZipFile.writestr() #139396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+4 −0
Open

Note SOURCE_DATE_EPOCH support in ZipFile.writestr() #139396

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89dea0b
gh-123299: Copyedit What's New in 3.14
Wulian233 Sep 28, 2025
fa92f66
Update 3.14.rst
Wulian233 Oct 3, 2025
764aadf
Update 3.14.rst
Wulian233 Oct 3, 2025
28b6b6c
Update 3.14.rst
Wulian233 Oct 3, 2025
feec370
Update 3.14.rst
Wulian233 Oct 3, 2025
c4ce0c6
Update zipfile.rst
Wulian233 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Doc/library/zipfile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,9 @@ ZipFile Objects
a closed ZipFile will raise a :exc:`ValueError`. Previously,
a :exc:`RuntimeError` was raised.

.. versionchanged:: 3.14
Now respects :envvar:`SOURCE_DATE_EPOCH` environment variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text can be improved here. The sentence lacks an object, but more importantly we don't say what has actually changed in the method's behaviour if SDE is set.

A

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

.. versionchanged:: 3.14
  :meth:`.ZipFile.writestr` now respects the :envvar:`SOURCE_DATE_EPOCH` environment variable. If set, it uses this value as the modification timestamp for the file written into the ZIP archive.

This will better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


.. method:: ZipFile.mkdir(zinfo_or_directory, mode=511)

Create a directory inside the archive. If *zinfo_or_directory* is a string,
Expand Down
Loading