-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-139590: Stricter ruff rules for Tools/wasm
#139752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "YTT", # flake8-2020 | ||
| ] | ||
| ignore = [ | ||
| "E501", # Line too long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this one makes likely sense given we're auto-formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to keep it, so we can reduce the diff :)
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
) (cherry picked from commit 678e0b8) Co-authored-by: sobolevn <[email protected]>
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
GH-139811 is a backport of this pull request to the 3.14 branch. |
|
…139811) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sorry, I was late for #139591 review :)
I propose to remove
ignorerules, because they are not actual for the code in this folder.